ok ruff lint is failing but all other tests pass

This might significantly increase our support issues.

These changes should probably land first on https://github.com/nodejs/gyp-next

Please install https://docs.astral.sh/ruff locally because those errors cannot be ignored.

This might significantly increase our support issues.

So you mean it increases the platform support?
this fixes

• MSYS2-MinGW64: Auto Generated Makefiles Give Error: target pattern contains no '%' #3120
• Using node-gyp in Windows with Windows version of Node and Python and MSYS2 GCC #3079
• Support for mingw/msys/cygwin for node-gyp #1240
• Support for MinGW/Cygwin as an alternative to Visual Studio #194

I mean that it will open more https://github.com/nodejs/node-gyp/issues for a volunteer group of maintainers to triage.

I mean that it will open more https://github.com/nodejs/node-gyp/issues for a volunteer group of maintainers to triage.

because more people will use node-gyp since it will fix something that was broken? That might be true. Is that the reason why it was not fixed?
But it will also close at least 2 issues, and will prevent the same issue about not allowing msys2 from coming up on node-gyp. About gyp-next, unfortunately it is way too different for this patchset to work. And more repos depend on node-gyp and not gyp-next.

I will try submitting a patch for gyp-next but it wont be anytime soon, since it is basically a rewrite.

also with this, you can work with a fork of https://github.com/Kreijstal/node-ffi-napi/tree/master ffi-napi.. since of course it is msvc biased..

• PLEASE ARCHIVE THIS REPO -- The code fails on modern Node.js node-ffi-napi/node-ffi-napi#269 is not something that I would recommend as a building block. There are tons of forks, but no community behind that tool.

currently it is the only option on msys2, since broooklyn will never update napi-sys. And koffi.rs does not work in msys2 either

will this ever be merged? It would be nice to not have to depend on bloated and proprietary msvc for building my dependencies

will this ever be merged? It would be nice to not have to depend on bloated and proprietary msvc for building my dependencies

just copy the files manually it seems to work for me, using msys2

@meghdip-fenrir I forgot to mention I also use this patch https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-nodejs/0103-node-gyp-support-mingw-toolchain.patch

Works great, thank you!

anything else to be fixed?

This branch has git conflicts that must be resolved

anything else to be fixed?

I mean I can keep trying to keep up but not sure if this is planned to get merged

Sorry, I've found your fork is for MSYS2 node-gyp. will you do anything for allowing using MSYS2 GCC for Windows node-gyp?

isn't the fix the same? I haven't had time to look into it, since upstream msys2 did patch some issues a lot of my code is not needed, however some parts are still needed... you would have to... try it and see..